Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataLad containers-run (and a bit on DataLad extensions) #242

Merged
merged 39 commits into from
Dec 5, 2019
Merged

DataLad containers-run (and a bit on DataLad extensions) #242

merged 39 commits into from
Dec 5, 2019

Conversation

adswa
Copy link
Contributor

@adswa adswa commented Nov 5, 2019 •
edited
Loading

This section is on DataLad's extensions, and focuses specifically on datalad-containers.
I have added an overview of existing extensions in the section "Further options". I have included a section on datalad containers in the chapter after the yoda principles/yoda project.

TODOs:

  • check which extensions should be mentioned in the books, get feedback on whether any particular extensions should be covered in more detail (i.e. standalone section) as well
  • write a singularity image for demonstration (just needs seaborn, pandas, sklearn), and make it publicly available
  • write section that introduces/demonstrates datalad containers run
  • write a short summary?

@adswa adswa mentioned this pull request Nov 5, 2019
Merged
5 tasks
@adswa
Copy link
Contributor Author

adswa commented Nov 11, 2019

This could work. I've written a basic Singularity image here. If rebased onto the top of the branch python (#226), this section allows to rerun the analysis performed in there within the container with datalad containers-run.

@adswa
Copy link
Contributor Author

adswa commented Nov 26, 2019

hey @mih, this in still WIP, but take a look at docs/basics/101-133-containersrun.rst if you want

@adswa adswa changed the title [WIP] On DataLad extensions DataLad containers-run (and a bit on DataLad extensions) Nov 27, 2019
mih
mih reviewed Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and almost ready. I left a bunch of comments, but nothing fundamental. Thx!

docs/basics/101-144-intro_extensions.rst Outdated Show resolved Hide resolved
docs/basics/101-144-intro_extensions.rst Outdated Show resolved Hide resolved
docs/basics/101-144-intro_extensions.rst Show resolved Hide resolved
docs/basics/101-144-intro_extensions.rst Outdated Show resolved Hide resolved
docs/basics/101-133-containersrun.rst Outdated Show resolved Hide resolved
docs/basics/101-133-containersrun.rst Outdated Show resolved Hide resolved
docs/basics/101-133-containersrun.rst Outdated Show resolved Hide resolved
docs/basics/101-133-containersrun.rst Show resolved Hide resolved
docs/basics/101-133-containersrun.rst Outdated Show resolved Hide resolved
docs/basics/101-134-summary.rst Outdated Show resolved Hide resolved
kyleam added a commit to kyleam/datalad-container that referenced this pull request Dec 4, 2019
@kyleam
DOC: basic demo: Update stale statement about Docker support
3099b11 
When that was written, the docker adapter wasn't available.  It's now
in the main source tree and is wired up to containers-add.

Re: datalad-handbook/book#242 (comment)
@kyleam kyleam mentioned this pull request Dec 4, 2019
Merged
@adswa
Copy link
Contributor Author

adswa commented Dec 4, 2019

Alrighty, I think I have addressed the comments - thx much for them, @mih!

mih
mih approved these changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mih mih merged commit b1a6a28 into master Dec 5, 2019
@mih mih deleted the extensions branch December 5, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleam kyleam kyleam left review comments

@mih mih mih approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adswa @mih @kyleam